Support constants in const eval #11772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodiebold
reviewed
Mar 20, 2022
There was a problem hiding this comment.
Looks good! We should really start having a proper test suite for this though.
I didn't find out how to find the ConstId of the implementation of the trait, not the trait itself (possibly related to #4558 ? We can find associated type alias, so maybe this is doable already)
That's exactly that issue. And yes, it's very similar to normalizing type aliases, but Chalk can't do it for functions or consts yet.
bors d+
|
✌️ HKalbasi can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables evaluating things like this:
My target was nalgebra's
U5,U22, ... which are defined astype U5 = Const<{ SomeType5::SOME_ASSOC_CONST }>but I didn't find out how to find theConstIdof the implementation of the trait, not the trait itself (possibly related to #4558 ? We can find associated type alias, so maybe this is doable already) So it doesn't help for nalgebra currently, but it is useful anyway.